chore(http): remove Apache HttpClient5, replace with RESTEasy client

[andrewazores]

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

---

Fixes: #382
Depends on #342
Depends on #368

Description of the change:

• removes Apache HttpClient5 dependency
• replaces HttpClient5 utilities with utilities from other dependencies (HTTP content type and response status code constants)
• replaces HttpClient5 actual client instance for sidecar report generation with RESTEasy client, which is The Quarkus Way and already a dependency

Motivation for the change:

One less dependency to manage, more idiomatic.

How to manually test:

1. Build PR (currently also needs manual merge of fix(reports): report generation does not cause recursive update #368)
2. ./smoketest.bash -OGr -s localstack
3. In another terminal, podman logs -f compose_reports_1
4. Open web client UI, generate a report
5. Check reports container log, verify that it received and processed the request (and therefore that the new HTTP client was used to send it the data)

[github-actions]

This PR/issue depends on:

• feat(agent): enable Agent HTTP communications #342
• fix(reports): report generation does not cause recursive update #368
  By Dependent Issues (🤖). Happy coding!

[andrewazores]

/build_test

[github-actions]

Workflow started at 4/24/2024, 1:42:06 PM. View Actions Run.

[github-actions]

No GraphQL schema changes detected.

[github-actions]

No OpenAPI schema changes detected.

[mwangggg]

hmm when I run ./mvnw clean packge, the some tests are failing and it's not consistent- mainly itest.ReportGenerationTest

[github-actions]

CI build and push: At least one test failed ❌ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8820915017

[andrewazores]

Seems like a weird failure, but I suppose it could have to do with the Future/Uni changes in the reports service implementation? I'll start there for troubleshooting.

Otherwise it could be a red herring and actually a problem that started with #396.

[mwangggg]

Seems like a weird failure, but I suppose it could have to do with the Future/Uni changes in the reports service implementation? I'll start there for troubleshooting.

Otherwise it could be a red herring and actually a problem that started with #396.

Suppressed: java.lang.RuntimeException: Error injecting io.cryostat.reports.ReportSidecarService io.cryostat.reports.ReportsServiceImpl.sidecar
		at io.cryostat.reports.ReportsServiceImpl_Bean.doCreate(Unknown Source)
		at io.cryostat.reports.ReportsServiceImpl_Bean.create(Unknown Source)
		at io.cryostat.reports.ReportsServiceImpl_Bean.create(Unknown Source)
		at io.quarkus.arc.impl.AbstractSharedContext.createInstanceHandle(AbstractSharedContext.java:113)
		at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:37)
		at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:34)
		at io.quarkus.arc.impl.LazyValue.get(LazyValue.java:26)
		at io.quarkus.arc.impl.ComputingCache.computeIfAbsent(ComputingCache.java:69)
		at io.quarkus.arc.impl.AbstractSharedContext.get(AbstractSharedContext.java:34)
		at io.quarkus.arc.impl.ClientProxies.getApplicationScopedDelegate(ClientProxies.java:21)
		at io.cryostat.reports.ReportsServiceImpl_ClientProxy.arc$delegate(Unknown Source)
		at io.cryostat.reports.ReportsServiceImpl_ClientProxy.reportFor(Unknown Source)
		at io.cryostat.reports.Reports.getActive(Reports.java:148)
		at io.cryostat.reports.Reports$quarkusrestinvoker$getActive_6fb45eeb93da6d8561a31f41648f9370eb83b563.invoke(Unknown Source)
		at org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:29)
		at io.quarkus.resteasy.reactive.server.runtime.QuarkusResteasyReactiveRequestContext.invokeHandler(QuarkusResteasyReactiveRequestContext.java:141)
		at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:145)
		at io.quarkus.vertx.core.runtime.VertxCoreRecorder$14.runWith(VertxCoreRecorder.java:576)
		at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
		at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
		at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
		at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
		at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
		at java.base/java.lang.Thread.run(Thread.java:840)
	Caused by: java.lang.IllegalArgumentException: Unable to determine the proper baseUrl/baseUri. Consider registering using @RegisterRestClient(baseUri="someuri"), @RegisterRestClient(configKey="orkey"), or by adding 'quarkus.rest-client.reports.url' or 'quarkus.rest-client.reports.uri' to your Quarkus configuration
		at io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilder.configureBaseUrl(RestClientCDIDelegateBuilder.java:366)
		at io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilder.configureBuilder(RestClientCDIDelegateBuilder.java:64)
		at io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilder.build(RestClientCDIDelegateBuilder.java:59)
		at io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilder.createDelegate(RestClientCDIDelegateBuilder.java:42)
		at io.quarkus.rest.client.reactive.runtime.RestClientReactiveCDIWrapperBase.delegate(RestClientReactiveCDIWrapperBase.java:76)
		at io.quarkus.rest.client.reactive.runtime.RestClientReactiveCDIWrapperBase.<init>(RestClientReactiveCDIWrapperBase.java:30)
		at io.cryostat.reports.ReportSidecarService$$CDIWrapper.<init>(Unknown Source)
		at io.cryostat.reports.ReportSidecarService$$CDIWrapper_ClientProxy.<init>(Unknown Source)
		at io.cryostat.reports.ReportSidecarService$$CDIWrapper_Bean.proxy(Unknown Source)
		at io.cryostat.reports.ReportSidecarService$$CDIWrapper_Bean.get(Unknown Source)
		at io.cryostat.reports.ReportSidecarService$$CDIWrapper_Bean.get(Unknown Source)
		... 24 more

these are the logs I see if this helps...

[andrewazores]

Oh nice, thanks, that's very helpful. That could be a simple rebase issue actually.

[andrewazores]

/build_test

[github-actions]

Workflow started at 4/24/2024, 2:49:36 PM. View Actions Run.

[github-actions]

No GraphQL schema changes detected.

[github-actions]

No OpenAPI schema changes detected.

[github-actions]

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8821744400

[mwangggg]

looks good!