-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add OpenZeppelin example #199
base: next
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a valid exploit to test the bounty and add that to the unit test bench in Lua. Instead of deploying and sending a transaction to an exploit contract, we could have the exploit contract be a Forge script, which would allow us to broadcast transactions on behalf of any EOA, including the contract owner. We could avoid the long compilation process by defining a minimal Vm
interface with just the functions we need. What do you think?
No doubt!
The long compilation time is only a problem when doing it inside the machine. 😉 doubt: You mentioned above this test improvement as a "nice to have" thing and I agree. Do you think we should delay the publishing of the second tutorial until we implement this test improvement? |
You're right, but if the exploit is now a Forge script, the hacker would have to use
I do think it is important to test code before publishing it, yes. |
make test
locally also successfully