Bugfix: replace deprecated new-window with setWindowOpenHandler (#2293)

Co-authored-by: k9ert <[email protected]>
cryptoadvance · Mar 15, 2023 · 5e98862 · 5e98862
1 parent 6a4829e
commit 5e98862
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/pyinstaller/electron/main.js b/pyinstaller/electron/main.js
@@ -364,10 +364,11 @@ function initMainWindow() {
     webPreferences
   })
 
-  mainWindow.webContents.on('new-window', function(e, url) {
-    e.preventDefault();
-    shell.openExternal(url);
-  });
+  // Ensures that any links with target="_blank" or window.open() will be opened in the user's default browser instead of within the app
+  mainWindow.webContents.setWindowOpenHandler(({ url }) => {
+    shell.openExternal(url)
+    return { action: 'deny' }
+  })
 
   mainWindow.on('close', function (event) {
       if(platformName == 'win64') {