remap offsets from bytes to chars during source map conversion #2661
+20
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaps byte offsets to char offsets in the
_convert_source_mapping
method of theSource
class.This method now:
Assumptions:
Problem:
if f not in sourceUnits
then we don't have reliable access to the source filename or code so we can't use the aforementioned method to convert to byte offsets. It's not clear to me when or why this logic branch would be taken, however.