Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Pivotal Tracker Link][tracker]
https://www.pivotaltracker.com/n/projects/2406982/stories/187044317
What this PR does:
This pull request fixes the resend_welcome_email redirect to use the original page of the user instead of a hardcoded path. The "Resend Welcome Email" button is in multiple locations of the app, so hardcoding a path would not work too well.
How should this PR be tested?
Already added RSpec testing, but manual testing can be done.
What do the specs/features test?
They test that the redirect_back works from multiple http links. They test for the two locations (that I know of) in the app that the button is present in and if redirect_back works.
Are there edge cases to watch out for?
Maybe if the user tries to run http://root/teachers/:id/edit/resend_welcome_email(email_format) directly into the searchbar, but even if someone does try that, the fallback will cover it.
Checklist:
michael/12345-add-new-feature
Any branch name will do as long as the story ID is there. You can usegit checkout -b [new-branch-name]
)