Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit redirect to use current path #33

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

JacksonXu33
Copy link

@JacksonXu33 JacksonXu33 commented Feb 27, 2024

[Pivotal Tracker Link][tracker]

https://www.pivotaltracker.com/n/projects/2406982/stories/187044317

What this PR does:

This pull request fixes the resend_welcome_email redirect to use the original page of the user instead of a hardcoded path. The "Resend Welcome Email" button is in multiple locations of the app, so hardcoding a path would not work too well.

How should this PR be tested?

Already added RSpec testing, but manual testing can be done.

  • What do the specs/features test?
    They test that the redirect_back works from multiple http links. They test for the two locations (that I know of) in the app that the button is present in and if redirect_back works.

  • Are there edge cases to watch out for?
    Maybe if the user tries to run http://root/teachers/:id/edit/resend_welcome_email(email_format) directly into the searchbar, but even if someone does try that, the fallback will cover it.

Checklist:

  • Has this been deployed to a staging environment or reviewed by a customer?
  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (d9d096d) to head (c64216f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files          20       20           
  Lines         668      668           
=======================================
  Hits          573      573           
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArushC
Copy link

ArushC commented Feb 28, 2024

LGTM.

@ArushC ArushC merged commit d1a4b1d into main Feb 28, 2024
10 checks passed
@ArushC ArushC deleted the feature/187044317-edit-resend-welcome-email-redirect branch February 28, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants