Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187167947/test/deny or request more info #36

Closed
wants to merge 4 commits into from

Conversation

perryzjc
Copy link
Member

@perryzjc perryzjc commented Mar 5, 2024

Pivotal Tracker Link

What this PR does:

This pull request

  1. add more tests for request info reason & denial reason.
  2. add empty reason input validation
  3. refract test step to improve cucumber test readability for non-technical person

Include screenshots, videos, etc.

image image

Who authored this PR?

  1. Perry (Jingchao) Zhong

How should this PR be tested?

  • Is there a deploy we can view?
  • What do the specs/features test?
  1. Test empty reason input for request more info reason/denial reason
    • No new email sent out
    • Dialog box not closed
  • Are there edge cases to watch out for?
    No idea.

Are there any complications to deploying this?

Nope.

Checklist:

  • Has this been deployed to a staging environment or reviewed by a customer?
  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (df52d67) to head (38fca3b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files          20       20           
  Lines         668      668           
=======================================
  Hits          573      573           
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArushC
Copy link

ArushC commented Mar 5, 2024

Everything looks good. But I am not sure if "Requesting more information from a teacher without specifying a reason as an admin should not send email" and "Denying teacher without specifying a reason as an admin should not send email". To be verified w/ Michael at the customer meeting tomorrow.

@ArushC ArushC closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants