187129573 change teacher status

[ArushC]

Pivotal Tracker Link

What this PR does:

Allows changing a teacher's application status. The frontend was demonstrated at the customer meeting. Look at the Cucumber tests to verify that the feature works as intended.

This pull request fixes|implements (pick one...) ______.

Include screenshots, videos, etc.

Who authored this PR?

Arush

How should this PR be tested?

• Is there a deploy we can view?

Yes: https://sp24-01-bjc-teachers-d0e972207d82.herokuapp.com/dashboard

• What do the specs/features test?
• Are there edge cases to watch out for?

Are there any complications to deploying this?

Checklist:

• Has this been deployed to a staging environment or reviewed by a customer?
• Tag someone for code review (either a coach / team member)
• I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

[codecov]

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 72.81%. Comparing base (d1a4b1d) to head (dd8da63).
Report is 34 commits behind head on main.

Files	Patch %	Lines
app/controllers/teachers_controller.rb	63.63%	4 Missing ⚠️
app/models/teacher.rb	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #39       +/-   ##
===========================================
- Coverage   85.77%   72.81%   -12.97%     
===========================================
  Files          20       20               
  Lines         668      813      +145     
===========================================
+ Hits          573      592       +19     
- Misses         95      221      +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[perryzjc]

@ArushC The functionality & cucumber tests look good to me. If there is anything I can suggest, there might be some styling issues, such as unnecessary comments.

[ArushC]

@perryzjc fixed styling and added coverage for one untested line

[perryzjc]

Um, I tried many ways of resolving conflict without merging main back to this branch, it didn't work. May be just ask Michael tmr and then figure out a way to merge this branch back to the main.

For presentation purpose, looks like Arush already deployed it to Heroku. I also gonna manually merge this branch to my local main branch to present the work for iteration 2 tmr.