187263439 clean schools #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
===========================================
- Coverage 86.18% 69.94% -16.25%
===========================================
Files 20 20
Lines 695 692 -3
===========================================
- Hits 599 484 -115
- Misses 96 208 +112 ☔ View full report in Codecov by Sentry. |
|
Ignore this PR for now. There is a heinous bug in the Cucumber tests that I cannot figure out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal Tracker Link
What this PR does:
Note: I am confident in these changes, so I merged them directly into the international schools branch. There is still an open PR from the international schools branch to the golden repo.
This PR fixes the Javascript that toggles the state "required" field when the country selected is/is not the USA. It also changes the frontend for the schools edit page so that the appropriate fields are now "required", and a JS popup appears that prevents you from submitting the form in the first place if the information that you are trying to submit is invalid. Earlier, it would let you submit the school if some info was invalid, but a flash message would appear. I completely removed this functionality and updated the tests accordingly.
This pull request fixes|implements (pick one...) ______.
Include screenshots, videos, etc.
Who authored this PR?
@ArushC
How should this PR be tested?
Yes:
I added some additional test cases for invalid country and random state field for a non-USA country.
nah
Are there any complications to deploying this?
Checklist:
michael/12345-add-new-featureAny branch name will do as long as the story ID is there. You can usegit checkout -b [new-branch-name])