-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align frontend for PD CRUD to be similar to the schools page #44
Align frontend for PD CRUD to be similar to the schools page #44
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pd-frontend+backend #44 +/- ##
========================================================
- Coverage 86.18% 71.56% -14.63%
========================================================
Files 20 24 +4
Lines 695 837 +142
========================================================
Hits 599 599
- Misses 96 238 +142 ☔ View full report in Codecov by Sentry. |
@perryzjc @realmichaeltao everything looks good overall. A couple of comments:
|
I'm just going to merge this branch to frontend+backend branch so that backend can branch off of this. |
Pivotal Tracker Link
What This PR Does:
This PR accomplishes the following tasks:
expect(Teacher.exists?(email:)).to be false
). Tests should be created after the model, schema, and controllers are properly set up.This pull request fixes|implements (pick one...) implements.
Include screenshots, videos, etc.
Overall Pages - Index Page
Overall Pages - Create New PD Page
Overall Pages - Edit PD Page
Overall Pages - Show Page
Frontend Behaviors - Add Teacher at
After hit `submit`, current mockup behavior for controller is to show `Create feature is not yet implemented.`Show
PageFrontend Behaviors - Update Teacher at
Show
PageIt automatically fills in the data from the selected record to the modal.
After hit
submit
, current mockup behavior for controller is to showUpdate feature is not yet implemented.
Frontend Behaviors - Delete Teacher at
Show
PageAfter hit
❌
, current mockup behavior for controller is to showDestroy feature is not yet implemented.
Frontend Behaviors - Delete/Update PD itself (not teacher)
Same as before, they all gonna show as
XX feature is not yet implemented.
Who authored this PR?
How should this PR be tested?
Test its frontend behaviors & ability to integrate with backends
Are there any complications to deploying this?
No. It's just a new frontend feature and does not break any existing test.
Checklist:
michael/12345-add-new-feature
Any branch name will do as long as the story ID is there. You can usegit checkout -b [new-branch-name]
)