Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher homeschool feature #56

Merged
merged 29 commits into from
Apr 26, 2024
Merged

Teacher homeschool feature #56

merged 29 commits into from
Apr 26, 2024

Conversation

ArushC
Copy link

@ArushC ArushC commented Apr 23, 2024

[Pivotal Tracker Link][tracker]

[tracker]: https://www.pivotaltracker.com/story/show/187479544, https://www.pivotaltracker.com/story/show/187460461, https://www.pivotaltracker.com/story/show/187460457, https://www.pivotaltracker.com/story/show/187460456

What this PR does:

A summary of relevant changes:

  • Adds a status option "I am teaching homeschool with the BJC curriculum" to the status dropdown
  • Iff the homeschool status option is selected, the teacher has the option to upload supporting files
  • The teacher can upload additional supporting files by editing their profile
  • The admin can both add and delete any teacher's supporting files

A future PR might add functionality to allow teachers to delete files that they uploaded by. This might be done by, for example, "marking" files to be purged when a teacher updates their profile from the edit teacher page.

This pull request fixes|implements (pick one...) ______.

Include screenshots, videos, etc.

Screen Shot 2024-04-23 at 1 41 59 PM Screen Shot 2024-04-23 at 1 42 22 PM

Who authored this PR?

@ArushC

How should this PR be tested?

Look at the Cucumber tests to verify that everything works as intended.

  • Is there a deploy we can view?

The Heroku deployment is currently buggy. I am working to resolve issues, and I will update this description when it gets figured out.

  • What do the specs/features test?

  • Are there edge cases to watch out for?

Are there any complications to deploying this?

Nope

Checklist:

  • Has this been deployed to a staging environment or reviewed by a customer?
  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay) (e.g. michael/12345-add-new-feature Any branch name will do as long as the story ID is there. You can use git checkout -b [new-branch-name])

@ArushC ArushC merged commit 204bf60 into main Apr 26, 2024
6 checks passed
@ArushC ArushC deleted the teacher-homeschool-feature branch April 26, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants