Node with typings #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point to the local compilation instructions of cs3apis.
…ocal-instructions
|
This produces the content of cs3org/node-cs3apis#10 |
labkode
approved these changes
Nov 3, 2021
|
Ah, sorry for breaking the build! I'll prepare a new PR. |
|
Reproduced the problem using the instructions which this PR adds to the readme (but with root@0ef91683dc6b:~/cs3apis# /root/cs3apis-build/cs3apis-build -build-node
Building Node.js ...
build [git clone --quiet https://github.com/cs3org/node-cs3apis]
. [git rev-parse --abbrev-ref HEAD]
build/node-cs3apis [git rev-parse --abbrev-ref HEAD]
Proto branch: main
Build branch: main
google/protobuf/field_mask.proto: File not found. |
|
And more directly: root@0ef91683dc6b:~/cs3apis# /usr/lib/node_modules/protoc-gen-grpc/bin/protoc --plugin=protoc-gen-ts=/usr/lib/node_modules/protoc-gen-grpc/bin/protoc-gen-ts-plugin --ts_out=grpc_js:./build/node-cs3apis cs3/gateway/v1beta1/gateway_api.proto cs3/gateway/v1beta1/resources.proto cs3/permissions/v1beta1/permissions_api.proto cs3/permissions/v1beta1/resources.proto cs3/preferences/v1beta1/preferences_api.proto cs3/rpc/v1beta1/code.proto cs3/rpc/v1beta1/status.proto cs3/tx/v1beta1/resources.proto cs3/tx/v1beta1/tx_api.proto cs3/types/v1beta1/types.proto cs3/admin/group/v1beta1/group_api.proto cs3/admin/user/v1beta1/user_api.proto cs3/app/provider/v1beta1/provider_api.proto cs3/app/provider/v1beta1/resources.proto cs3/app/registry/v1beta1/registry_api.proto cs3/app/registry/v1beta1/resources.proto cs3/auth/applications/v1beta1/applications_api.proto cs3/auth/applications/v1beta1/resources.proto cs3/auth/provider/v1beta1/provider_api.proto cs3/auth/provider/v1beta1/resources.proto cs3/auth/registry/v1beta1/registry_api.proto cs3/auth/registry/v1beta1/resources.proto cs3/identity/group/v1beta1/group_api.proto cs3/identity/group/v1beta1/resources.proto cs3/identity/user/v1beta1/resources.proto cs3/identity/user/v1beta1/user_api.proto cs3/ocm/core/v1beta1/ocm_core_api.proto cs3/ocm/core/v1beta1/resources.proto cs3/ocm/invite/v1beta1/invite_api.proto cs3/ocm/invite/v1beta1/resources.proto cs3/ocm/provider/v1beta1/provider_api.proto cs3/ocm/provider/v1beta1/resources.proto cs3/sharing/collaboration/v1beta1/collaboration_api.proto cs3/sharing/collaboration/v1beta1/resources.proto cs3/sharing/link/v1beta1/link_api.proto cs3/sharing/link/v1beta1/resources.proto cs3/sharing/ocm/v1beta1/ocm_api.proto cs3/sharing/ocm/v1beta1/resources.proto cs3/storage/provider/v1beta1/provider_api.proto cs3/storage/provider/v1beta1/resources.proto cs3/storage/registry/v1beta1/registry_api.proto cs3/storage/registry/v1beta1/resources.proto
google/protobuf/field_mask.proto: File not found. |
|
Ah, this works: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.