Skip to content

Commit

Permalink
Add lock to TouchFile + minor comments (#232)
Browse files Browse the repository at this point in the history
* [comment-only] mark OCM provider fields optional

* Add optional lock to TouchFile
  • Loading branch information
glpatcern authored Nov 5, 2024
1 parent f869434 commit f02b2a2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cs3/ocm/provider/v1beta1/resources.proto
Original file line number Diff line number Diff line change
Expand Up @@ -81,19 +81,19 @@ message ProviderInfo {
// REQUIRED.
// The full name of the provider.
string full_name = 2;
// REQUIRED.
// OPTIONAL.
// A description of the provider.
string description = 3;
// REQUIRED.
// OPTIONAL.
// The organization to which the provider belongs.
string organization = 4;
// REQUIRED.
// The domain of the sync'n'share provider.
string domain = 5;
// REQUIRED.
// OPTIONAL.
// The homepage of the provider.
string homepage = 6;
// REQUIRED.
// OPTIONAL.
// The email at which the provider can be reached.
string email = 7;
// REQUIRED.
Expand Down
5 changes: 5 additions & 0 deletions cs3/storage/provider/v1beta1/provider_api.proto
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,11 @@ message TouchFileRequest {
// REQUIRED.
// The reference to which the action should be performed.
Reference ref = 2;
// OPTIONAL.
// A lock_id: should the reference be locked, the stored
// lock_id MUST be equal to the given value. However, implementations
// MAY allow touching an existing file even with a mismatching lock.
string lock_id = 3;
}

message TouchFileResponse {
Expand Down

0 comments on commit f02b2a2

Please sign in to comment.