handle empty traces (#5028)

cs3org · Jan 7, 2025 · cc2dd41 · cc2dd41
1 parent b2059f6
commit cc2dd41
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/changelog/unreleased/better-eos-traces.md b/changelog/unreleased/better-eos-traces.md
@@ -0,0 +1,3 @@
+Enhancement: Handle empty EOS traces
+
+https://github.com/cs3org/reva/pull/5028
diff --git a/pkg/eosclient/eosbinary/eosbinary.go b/pkg/eosclient/eosbinary/eosbinary.go
@@ -247,7 +247,10 @@ func (c *Client) executeEOS(ctx context.Context, cmdArgs []string, auth eosclien
 
 	cmd.Args = append(cmd.Args, cmdArgs...)
 
-	cmd.Args = append(cmd.Args, "--comment", trace.Get(ctx))
+	t := trace.Get(ctx)
+	if t != "" {
+		cmd.Args = append(cmd.Args, "--comment", t)
+	}
 
 	err := cmd.Run()
 

diff --git a/pkg/storage/fs/cephfs/errors.go b/pkg/storage/fs/cephfs/errors.go
@@ -28,8 +28,8 @@ package cephfs
 */
 import "C"
 import (
-	"fmt"
 	"context"
+	"fmt"
 	"github.com/cs3org/reva/pkg/appctx"
 	"github.com/cs3org/reva/pkg/errtypes"
 )
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Enhancement: Handle empty EOS traces

		https://github.com/cs3org/reva/pull/5028