csmock: make kfp work for pkgs without the -release suffix
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Nov 3, 2023
The code that extracts package name from the `name-version-release` string did not work as expected if the `-release` part was missing. Consequently, it did not find the corresponding `exclude-paths.txt` file in the known-false-positives while scanning a source code tarball named: `RedHatInsights-compliance-backend-bd2b8accb3d4aae88a8c1a71563ec3f5ead7b1fa.tar.gz` Resolves: https://issues.redhat.com/browse/OSH-392 Closes: csutils#136
kdudka
force-pushed
the
missing-release
branch
from
e822623 to
921b941
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The code that extracts package name from the `name-version-release` string did not work as expected if the `-release` part was missing. Consequently, it did not find the corresponding `exclude-paths.txt` file in the known-false-positives while scanning a source code tarball named: `RedHatInsights-compliance-backend-bd2b8accb3d4aae88a8c1a71563ec3f5ead7b1fa.tar.gz` Resolves: https://issues.redhat.com/browse/OSH-392 Closes: csutils#136
kdudka
force-pushed
the
missing-release
branch
from
921b941 to
012cde3
Compare
hanchuntao
approved these changes
Nov 10, 2023
|
@hanchuntao Thanks for review! |
jperezdealgaba
pushed a commit
to jperezdealgaba/csmock
that referenced
this pull request
Nov 22, 2023
The code that extracts package name from the `name-version-release` string did not work as expected if the `-release` part was missing. Consequently, it did not find the corresponding `exclude-paths.txt` file in the known-false-positives while scanning a source code tarball named: `RedHatInsights-compliance-backend-bd2b8accb3d4aae88a8c1a71563ec3f5ead7b1fa.tar.gz` Resolves: https://issues.redhat.com/browse/OSH-392 Closes: csutils#136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that extracts package name from the
name-version-releasestring did not work as expected if the-releasepart was missing. Consequently, it did not find the correspondingexclude-paths.txtfile in the known-false-positives while scanning a source code tarball named:RedHatInsights-compliance-backend-bd2b8accb3d4aae88a8c1a71563ec3f5ead7b1fa.tar.gzResolves: https://issues.redhat.com/browse/OSH-392