Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csmock: make sure that tar is installed in chroot #144

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Dec 11, 2023

... because it is used by csmock itself while copying files into chroot. This commit fixes the following failure with --no-scan:

$ csmock -r rhel-8.9.0.z-x86_64 --use-host-cppcheck -o output.tar.xz
[...]
>>> 2023-12-11 10:12:01	"tar -cP '/usr/share/csmock/scripts' '/usr/bin/cswrap' '/usr/lib64/cswrap' '/usr/bin/csclng' '/usr/lib64/csclng' '/usr/bin/csclng++' '/usr/bin/cscppc' '/usr/lib64/cscppc' '/usr/share/cscppc' '/usr/bin/cppcheck' '/usr/share/Cppcheck' '/usr/bin/csgcca' '/usr/lib64/csgcca' '/tmp/csmockvujta3wk/gitleaks' | '/usr/bin/mock' '-r' 'rhel-8.9.0.z-x86_64' '--plugin-option=tmpfs:keep_mounted=True' '--config-opts=print_main_output=True' '--quiet' '--shell' 'tar -xC/'"
/bin/sh: tar: command not found

scan.ini: analyzer-version-clang = 16.0.6
!!! 2023-12-11 10:12:05	error: failed to query cppcheck version

@kdudka kdudka requested a review from lzaoral December 11, 2023 10:48
@kdudka kdudka self-assigned this Dec 11, 2023
... because it is used by `csmock` itself while copying files into
chroot.  This commit fixes the following failure with `--no-scan`:
```
$ csmock -r rhel-8.9.0.z-x86_64 --use-host-cppcheck -o output.tar.xz
[...]
>>> 2023-12-11 10:12:01	"tar -cP '/usr/share/csmock/scripts' '/usr/bin/cswrap' '/usr/lib64/cswrap' '/usr/bin/csclng' '/usr/lib64/csclng' '/usr/bin/csclng++' '/usr/bin/cscppc' '/usr/lib64/cscppc' '/usr/share/cscppc' '/usr/bin/cppcheck' '/usr/share/Cppcheck' '/usr/bin/csgcca' '/usr/lib64/csgcca' '/tmp/csmockvujta3wk/gitleaks' | '/usr/bin/mock' '-r' 'rhel-8.9.0.z-x86_64' '--plugin-option=tmpfs:keep_mounted=True' '--config-opts=print_main_output=True' '--quiet' '--shell' 'tar -xC/'"
/bin/sh: tar: command not found

scan.ini: analyzer-version-clang = 16.0.6
!!! 2023-12-11 10:12:05	error: failed to query cppcheck version
```
Closes: csutils#144
Copy link
Member

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kdudka kdudka merged commit f04a792 into csutils:main Dec 11, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants