Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

results: skip comments in exclude-paths.txt #150

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

stefan-cornelius
Copy link
Contributor

This allows comments in the path exlusion regex file. Instead of adding each line as a filtering rule, it skips empty lines and lines starting with a # symbol.

Fixes https://issues.redhat.com/browse/OSH-508

@stefan-cornelius
Copy link
Contributor Author

Just noticed the comment about the sanity check in OSH-508. Will add ...

@kdudka kdudka self-assigned this Jan 26, 2024
@kdudka kdudka self-requested a review January 26, 2024 13:34
@kdudka
Copy link
Member

kdudka commented Jan 26, 2024

@stefan-cornelius The code change looks good. Please delimit the commit title with a blank line as suggested in the git-commit(1) man page:

Though not required, it’s a good idea to begin the commit message with a single short (no more than 50 characters)
line summarizing the change, followed by a blank line and then a more thorough description. The text up to the first
blank line in a commit message is treated as the commit title, and that title is used throughout Git. For example,
git-format-patch(1) turns a commit into email, and it uses the title on the Subject line and the rest of the commit
in the body.

I propose this as the commit title: results: skip comments in exclude-paths.txt

@stefan-cornelius stefan-cornelius changed the title False Pos path excl: Add comment processing results: skip comments in exclude-paths.txt Jan 29, 2024
This allows comments in the path exlusion regex file. Instead of
adding each line as a filtering rule, it skips empty lines and
lines starting with a # symbol.

Fixes: https://issues.redhat.com/browse/OSH-508
Closes: csutils#150
@kdudka kdudka force-pushed the path-re-commentskip branch from 66eb473 to 9befcc3 Compare January 30, 2024 14:13
@kdudka
Copy link
Member

kdudka commented Jan 30, 2024

@stefan-cornelius Merging, thanks!

@kdudka kdudka closed this in 9befcc3 Jan 30, 2024
@kdudka kdudka merged commit 9befcc3 into csutils:main Jan 30, 2024
3 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants