Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csmock: support buildroot location used by new rpm #192

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Nov 7, 2024

The %{buildroot} directory we were looking into is no longer used by new versions of rpm. The directory was moved with the following backward-incompatible change: rpm-software-management/rpm@9d35c8d

This commit makes csmock look into both the locations.

Fixes: #191

No change in behavior intended with this commit.

Related: csutils#191
The `%{buildroot}` directory we were looking into is no longer used
by new versions of `rpm`.  The directory was moved with the following
backward-incompatible change:
rpm-software-management/rpm@9d35c8d

This commit makes csmock look into both the locations.

Fixes: csutils#191
Closes: csutils#192
@kdudka kdudka requested a review from siteshwar November 7, 2024 08:52
@kdudka kdudka self-assigned this Nov 7, 2024
Copy link
Member

@siteshwar siteshwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, although I have not tried this change in the staging environment.

@kdudka
Copy link
Member Author

kdudka commented Nov 7, 2024

@siteshwar Thanks for review!

@kdudka kdudka merged commit b3f0f26 into csutils:main Nov 7, 2024
40 checks passed
@kdudka kdudka deleted the new-rpm branch November 7, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csmock fails to find shellscripts
2 participants