Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irf maker and cut optimiser #2473

Merged
merged 195 commits into from
Feb 3, 2025

Fix binning for sensitivity

1ad6c54
Select commit
Loading
Failed to load commit list.
Merged

Irf maker and cut optimiser #2473

Fix binning for sensitivity
1ad6c54
Select commit
Loading
Failed to load commit list.
CTAO-DPPS-SonarQube / ctapipe Sonarqube Results succeeded Jan 31, 2025 in 14s

Quality Gate success

Passed

Analysis Details

9 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 9 Code Smells

Coverage and Duplications

  • Coverage 96.20% Coverage (93.90% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

Annotations

Check notice on line 173 in src/ctapipe/tools/tests/test_compute_irf.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

src/ctapipe/tools/tests/test_compute_irf.py#L173 

Complete the task associated to this "TODO" comment.

Check failure on line 49 in src/ctapipe/tools/tests/test_compute_irf.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

src/ctapipe/tools/tests/test_compute_irf.py#L49 

Define a constant instead of duplicating this literal "irf.fits.gz" 5 times.

Check failure on line 50 in src/ctapipe/tools/tests/test_compute_irf.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

src/ctapipe/tools/tests/test_compute_irf.py#L50 

Define a constant instead of duplicating this literal "benchmarks.fits.gz" 5 times.

Check failure on line 24 in src/ctapipe/tools/tests/test_optimize_event_selection.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

src/ctapipe/tools/tests/test_optimize_event_selection.py#L24 

Define a constant instead of duplicating this literal "cuts.fits" 3 times.

Check failure on line 456 in src/ctapipe/tools/compute_irf.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

src/ctapipe/tools/compute_irf.py#L456 

Refactor this function to reduce its Cognitive Complexity from 37 to the 15 allowed.

Check notice on line 402 in src/ctapipe/tools/compute_irf.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

src/ctapipe/tools/compute_irf.py#L402 

Complete the task associated to this "TODO" comment.

Check warning on line 85 in src/ctapipe/irf/tests/test_optimize.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

src/ctapipe/irf/tests/test_optimize.py#L85 

Rename this parameter "Optimizer" to match the regular expression ^[_a-z][a-z0-9_]*$.

Check failure on line 162 in docs/conf.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

docs/conf.py#L162 

Define a constant instead of duplicating this literal "py:meth" 3 times.

Check failure on line 154 in docs/conf.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

docs/conf.py#L154 

Define a constant instead of duplicating this literal "py:obj" 9 times.
View more details on CTAO-DPPS-SonarQube