Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sphinx-changelog #2657

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Use sphinx-changelog #2657

merged 1 commit into from
Nov 27, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 21, 2024

Replace custom solution with using sphinx-changelog, this also works on readthedocs and means we get the changelog previewed in the "latest" docs.

@maxnoe maxnoe added no-changelog-needed documentation-only Label that will ensure code tests are skipped labels Nov 21, 2024
@maxnoe maxnoe requested review from Tobychev and kosack November 21, 2024 17:44
@Tobychev
Copy link
Contributor

Results look identical between the CI version and latest, so I'm confused about what you mean by this "we get the changelog previewed"?

I can spot one behaviour change between the CI version and prod: when you scroll all the way up on the CI the right hand side content menu doesn't collapse down to one line per release like it does on prod.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 22, 2024

Results look identical between the CI version and latest,

That's because we haven't merged anything yet since the last tag

@Tobychev
Copy link
Contributor

I tried rerunning the docs build now that the Astropy 7 PR got merged but again I can't see anything being picked up... though github itself is not picking up #2639 in the "is:pr is:closed" view either?

@maxnoe
Copy link
Member Author

maxnoe commented Nov 26, 2024

But this branch is not updated with respect to main

@maxnoe maxnoe merged commit 7a26885 into main Nov 27, 2024
14 checks passed
@maxnoe maxnoe deleted the sphinx-changelog branch November 27, 2024 08:58
@maxnoe
Copy link
Member Author

maxnoe commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-only Label that will ensure code tests are skipped no-changelog-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants