-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gain selection to OSA workflow #230
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 82.06% 79.70% -2.37%
==========================================
Files 57 59 +2
Lines 4885 5144 +259
==========================================
+ Hits 4009 4100 +91
- Misses 876 1044 +168 ☔ View full report in Codecov by Sentry. |
follow-up on this PR, conflicts need to be solved |
Anyway, current gain selection program will not work with the data taken since early July in ADHF format, right? |
Ah, you're right! Then I guess this will have to be updated with whichever new tool we develop for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, if you have tested it also on actual data go ahead with the merging
Related to #227