-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lstcam_calib instead of lstchain for the calibration #310
Conversation
if command names are defined via cfg, the change is quite straightforward, just adapting the test to expect whatever command name is included in the test cfg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marialainez.
Try to use cfg.get in tests to get the command name expected. Otherwise looks good, the change is quite straightforward
ctapipe_io_lst v0.24 ready in conda forge already, running tests again with lstcam calib here |
I realized that to make the CI work with lstcam_calib and lstchain, lstosa should require lstchain >= 0.10.13 (which is the release that requires ctapipe_io_lst >= 0.24.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise it lstchain should be also updated to use "-" in the command line arguments
@marialainez, @rcervinoucm please modify tests accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
No description provided.