Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lstcam_calib instead of lstchain for the calibration #310

Merged
merged 12 commits into from
Dec 2, 2024

Conversation

marialainez
Copy link
Collaborator

No description provided.

@morcuended
Copy link
Member

if command names are defined via cfg, the change is quite straightforward, just adapting the test to expect whatever command name is included in the test cfg

Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marialainez.

Try to use cfg.get in tests to get the command name expected. Otherwise looks good, the change is quite straightforward

src/osa/configs/sequencer.cfg Show resolved Hide resolved
src/osa/scripts/tests/test_osa_scripts.py Outdated Show resolved Hide resolved
src/osa/scripts/tests/test_osa_scripts.py Outdated Show resolved Hide resolved
src/osa/tests/test_jobs.py Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
@morcuended
Copy link
Member

ctapipe_io_lst v0.24 ready in conda forge already, running tests again with lstcam calib here

@morcuended
Copy link
Member

I realized that to make the CI work with lstcam_calib and lstchain, lstosa should require lstchain >= 0.10.13 (which is the release that requires ctapipe_io_lst >= 0.24.0)

@morcuended morcuended marked this pull request as draft November 11, 2024 13:25
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise it lstchain should be also updated to use "-" in the command line arguments

src/osa/scripts/calibration_pipeline.py Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
@morcuended
Copy link
Member

@marialainez, @rcervinoucm please modify tests accordingly

@marialainez marialainez marked this pull request as ready for review December 2, 2024 10:02
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@marialainez marialainez merged commit 48f7e24 into main Dec 2, 2024
4 checks passed
@marialainez marialainez deleted the lstcam_calib branch December 2, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants