Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to page no loop fix #34

Closed
wants to merge 2 commits into from
Closed

Go to page no loop fix #34

wants to merge 2 commits into from

Conversation

ebi
Copy link

@ebi ebi commented Sep 26, 2012

If you disable looping and use a goToPage the masterPage 0 will stay as invisible but potentially the next page will be visible (which shouldn't) I didn't fully understand the system but removing the visibility hidden and rechecking the position seems to fix the situation.

@jmohsenin
Copy link

+1 this solved my issue. Thanks guys!

@dokterbob
Copy link

I have fired a new pull request with just @linlex patch, for which many thanks!

@ebi Perhaps a good idea to close this pull request to prevent people from applying a patch with known issues.

@ebi
Copy link
Author

ebi commented Feb 12, 2014

@dokterbob I haven't tried the @linlex fix. So I trust you on that one. Unfortunately it doesn't seem like @cubiq is merging stuff anyways.

@ebi ebi closed this Feb 12, 2014
@dokterbob
Copy link

Yeah, quite a pity. Perhaps he will some time in the future.

Thanks for the quick reaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants