Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 ci: add JDK21 in list of tested versions #365

Merged
merged 1 commit into from
Nov 27, 2023
Merged

📦 ci: add JDK21 in list of tested versions #365

merged 1 commit into from
Nov 27, 2023

Conversation

gaeljw
Copy link
Member

@gaeljw gaeljw commented Nov 5, 2023

No description provided.

@dfurmans
Copy link
Contributor

dfurmans commented Nov 26, 2023

[error] (cucumberScala2_12 / Compile / compileIncremental) Error compiling the sbt component 'compiler-bridge_2.12'

Could be related to configuration parameters 🤔

@gaeljw
Copy link
Member Author

gaeljw commented Nov 26, 2023

I think we should bump Scala 2.12 version. Apparently Renovate did not. We need at least 2.12.18 for JDK 21.

If you have a bit of time to open a PR, please do @dfurmans

@dfurmans
Copy link
Contributor

I have checked it and that is the point ! we need Scala 2.12.8 for JDK 21
Would love to do PR for that, but I am not a member of the project. To whom I can ask to add me as a member ❔
Thanks ! @gaeljw

@gaeljw
Copy link
Member Author

gaeljw commented Nov 27, 2023

Would love to do PR for that, but I am not a member of the project. To whom I can ask to add me as a member ❔ Thanks ! @gaeljw

@dfurmans You don't need to. You can fork the project and create a branch on your fork. Then you'll be able to open a PR here.

You can learn more about it here: https://docs.github.com/en/get-started/quickstart/contributing-to-projects

GitHub also provides stuff to do everything via your browser for such simple changes. If you go to a file you want to modify, you can click on "edit" (in this repo) and it'll automatically create the fork + open the PR for you.

@dfurmans
Copy link
Contributor

Here we are :
#366

@gaeljw gaeljw merged commit 8706047 into main Nov 27, 2023
5 checks passed
@gaeljw gaeljw deleted the java21 branch November 27, 2023 18:07
@gaeljw gaeljw added this to the 8.19.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants