-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests #34
Add unit tests #34
Conversation
…> to prevent eclipse warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fereira. This is looking good. A few questions:
- Did we get a 👍🏼 from @starsplatter to commit the MARC files? They don't appear to be sanitized
- If I remove
-DskipTests=true
from the Dockerfile, all tests fail when building the Docker image. Do you want me to push a commit that adds test support for the containers or do you prefer to keep that in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sanitized
I hadn't tested it in a container. I prefer not to use containers on my development machine for developing code. I'd like to get tests merged so that I can work on other issues and have tests that I can work on for the new issues (e.g. the map notes issue). |
Sounds good. We'll leave it as is for now and won't have tests run as part of the deploy. Feel free to merge when you're ready.
|
Do you know if there is a "standard" way to put unit tests which require external files to execute? I'm wondering if part of the deploy process would be to copy them to a "named" volume in the container that's referenced by an ENV variable. |
We can just copy them to the build artifact so that maven can run the tests. I opened a draft PR so you can see for yourself. |
Adding this PR to create unit tests for Lookup utils, MarcUtils, and ApiServices...these are just basic tests for now that can be built upon