Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add billing UUID to PO #40

Merged
merged 11 commits into from
May 19, 2021
Merged

Add billing UUID to PO #40

merged 11 commits into from
May 19, 2021

Conversation

fereira
Copy link

@fereira fereira commented May 18, 2021

  • adds a map containing billing address as a lookup table
  • uses billTo environment variable as a key to get billing address UUID
  • validates that billTo and other required env vars have been set

Resolves #26

@fereira fereira requested a review from cappadona May 19, 2021 12:35
Copy link

@cappadona cappadona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is, this will not add a billing address to POs when deployed. We need to add the billTo environment variable to the .env file that is currently stored in an S3 bucket. I will follow up in Slack.

I also have a couple suggestions for refining the API call when retrieving the tenant addresses and the ensuing logic when building the lookup map.

@fereira fereira requested a review from cappadona May 19, 2021 14:45
.env.example Outdated Show resolved Hide resolved
@cappadona
Copy link

@fereira I've updated the .env in the S3 bucket so feel free to merge at your leisure.

@fereira fereira merged commit 28765a3 into main May 19, 2021
@fereira fereira deleted the add-billTo branch May 19, 2021 15:57
@cappadona cappadona mentioned this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bill to/ship to address to PO
2 participants