Multisession modeling changes for AutoLFADS #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cellistigs
reviewed
Sep 7, 2023
| obj_keyname = obj.key | ||
| if (os.path.basename(obj_keyname) in os.listdir(localpath)) and (not force): | ||
| print("Data already exists at this location. Set force = true to overwrite") | ||
| return 0 |
There was a problem hiding this comment.
Is this a way to 1) check if the folder we are writing to is empty? Or rather 2) to save time by refraining from re-downloading files?
Forgive me if I'm misunderstanding, but if 1) I think we'd want to check ahead of time, and not have things tied to individual file names. If 2)wouldn't we want to continue iterating other files even if one exists?
There was a problem hiding this comment.
You're right that this doesn't make sense. I'll modify to 2.
tests/test_Interface_S3.py
Outdated
| return bucketname,username,data_dirname,config_dirname,s3_client,s3_resource | ||
|
|
||
|
|
||
| # def test_download(setup_simple_bucket,tmp_path): |
There was a problem hiding this comment.
Can you restore this test (and test_upload?)
tests/test_scripting.py
Outdated
There was a problem hiding this comment.
Likewise, if you can restore tests here (including those that are skipped)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.