Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use prices api for llamma trades #633

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

0xAlunara
Copy link
Collaborator

@0xAlunara 0xAlunara commented Jan 25, 2025

  • I temporarily put the duplicated date utility functions inside packages\ui\src\utils\utilsDate.ts. I didn't want to clog curve-ui-kit with what is most likely a temporary util functions and not really related to any other ui components. Also didn't want to introduce yet another shared or utils function inside the app folder.
  • Affects the LLAMMA Activity table inside dex pools, lending pools and crvusd pools.
  • Decided not to opt for (more logical) renames of existing code to keep the PR small

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curve-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 0:03am
curve-dapp-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 0:03am

@0xAlunara 0xAlunara marked this pull request as draft January 27, 2025 18:50
@0xAlunara 0xAlunara force-pushed the refactor/prices-api-llama-ohlc branch from d0406e2 to ac223b1 Compare January 29, 2025 15:22
OnlyJousting
OnlyJousting previously approved these changes Jan 29, 2025
Base automatically changed from refactor/prices-api-llama-ohlc to main January 30, 2025 18:16
@0xAlunara 0xAlunara dismissed OnlyJousting’s stale review January 30, 2025 18:16

The base branch was changed.

@0xAlunara 0xAlunara merged commit 95261ff into main Feb 3, 2025
5 checks passed
@0xAlunara 0xAlunara deleted the refactor/prices-api-llama-trades branch February 3, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants