refactor: rename notify calls
#651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xAlunara
approved these changes
Jan 29, 2025
| @@ -84,6 +84,7 @@ const TableSettings = ({ | |||
| searchText={searchParams.searchText} | |||
| handleInputChange={(val) => updatePath({ searchText: val })} | |||
| handleClose={() => updatePath({ searchText: '' })} | |||
| testId="search-pools" | |||
There was a problem hiding this comment.
sorry out of context but the cypress tests were broken 😨
| @@ -102,15 +102,15 @@ const LoanCreate = ({ isLeverage = false, ...pageProps }: PageContentProps & { i | |||
| maxSlippage: string, | |||
| isLeverage: boolean, | |||
| ) => { | |||
| const notify = notifyNotification(NOFITY_MESSAGE.pendingConfirm, 'pending') | |||
| const notification = notify(NOFITY_MESSAGE.pendingConfirm, 'pending') | |||
There was a problem hiding this comment.
const { dismiss }? Would also allow you to get rid of that ?. below I think when calling it
There was a problem hiding this comment.
that ?. is probably not necessary in some (most?) places, just didn't take the time to go through each one.
imo notification.dismiss() is more expressive
OnlyJousting
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notify as notifyNotificationbynotify