Code

add features and tests#2

Code

Merged

bout3fiddy merged 76 commits intomaincurvefi/twocrypto-ng:mainfrom feat/testscurvefi/twocrypto-ng:feat/testsCopy head branch name to clipboardDec 23, 2023

+5,236-512

Commits

Commits on Oct 5, 2023

• bump gauge version

  bout3fiddy

  committed
  44a7bf8

  Copy full SHA for 44a7bf8

• feat: add exchange_received_split experimental idea; fix: upkeep xcp oracle in remove_liquidity

  bout3fiddy

  committed
  42bff31

  Copy full SHA for 42bff31

• add docstrings to exchange_received_split

  bout3fiddy

  committed
  b0aecd0

  Copy full SHA for b0aecd0

Commits on Oct 6, 2023

• add distinction between split_in and split_out

  bout3fiddy

  committed
  be077a2

  Copy full SHA for be077a2

Commits on Oct 9, 2023

• fix: isqrt precision issues; tests

  bout3fiddy

  committed
  d3a6282

  Copy full SHA for d3a6282

• fix extra accounting of dx received

  bout3fiddy

  committed
  58ff178

  Copy full SHA for 58ff178

Commits on Oct 11, 2023

• add cicd

  bout3fiddy

  committed
  d879e4c

  Copy full SHA for d879e4c

• update boa

  bout3fiddy

  committed
  ca4317c

  Copy full SHA for ca4317c

• fix path

  bout3fiddy

  committed
  7797ad4

  Copy full SHA for 7797ad4

• update limits in tests

  bout3fiddy

  committed
  39963c8

  Copy full SHA for 39963c8

• remove print; ignore flake8

  bout3fiddy

  committed
  d2e7fec

  Copy full SHA for d2e7fec

• add fuzz

  bout3fiddy

  committed
  aea8d70

  Copy full SHA for aea8d70

Commits on Nov 1, 2023

• begin stateful tests

  bout3fiddy

  committed
  97a644b

  Copy full SHA for 97a644b

• fix: rearrange calcs to avoid overflow

  bout3fiddy

  committed
  6ab6f4a

  Copy full SHA for 6ab6f4a

• fix: ramp A gamma with old xp[i] value and not new one

  bout3fiddy

  committed
  3c3e29a

  Copy full SHA for 3c3e29a

• claim admin virtual balances as well

  bout3fiddy

  committed
  4d76e11

  Copy full SHA for 4d76e11

Commits on Nov 2, 2023

• only proportion goes to admin lp virtual balance

  bout3fiddy

  committed
  e601564

  Copy full SHA for e601564

• introduce spot portfolio and account for portfolio balance in _transfer_in: this prevents hackers from stealing from spot wallets

  bout3fiddy

  committed
  71c58d6

  Copy full SHA for 71c58d6

• only msg.sender can deposit or withdraw from spot wallet

  bout3fiddy

  committed
  05d0b4f

  Copy full SHA for 05d0b4f

Commits on Nov 5, 2023

• Change range of params for get_y unitary test.

  

  Filipp

  committed
  f901e54

  Copy full SHA for f901e54

Commits on Nov 6, 2023

• fix: error using cached price instead of uncached for price oracle

  bout3fiddy

  committed
  3be3a0f

  Copy full SHA for 3be3a0f

• Merge branch 'feat/tests' of https://github.com/curvefi/twocrypto-ng into feat/tests

  bout3fiddy

  committed
  244144f

  Copy full SHA for 244144f

• change max limits for gamma and A (found by filipp after rigorous testing

  bout3fiddy

  committed
  5eceae4

  Copy full SHA for 5eceae4

• use pragma instead

  bout3fiddy

  committed
  53a8e46

  Copy full SHA for 53a8e46

• fix: redesign exchange_received_split to relax out amounts

  bout3fiddy

  committed
  4352c72

  Copy full SHA for 4352c72

• fix: use correct amounts

  bout3fiddy

  committed
  026afab

  Copy full SHA for 026afab

Commits on Nov 8, 2023

• goodbye spot wallet idea. you were good but not good enough

  bout3fiddy

  committed
  5500457

  Copy full SHA for 5500457

• fix limits and remove spot wallet tests

  bout3fiddy

  committed
  0e33774

  Copy full SHA for 0e33774

Commits on Nov 9, 2023

• remove ape

  bout3fiddy

  committed
  d102eaf

  Copy full SHA for d102eaf

• remove mentions of tricrypto

  bout3fiddy

  committed
  6a22fe4

  Copy full SHA for 6a22fe4

• remove k reference

  bout3fiddy

  committed
  70c89a4

  Copy full SHA for 70c89a4

Commits on Nov 12, 2023

• Fix get_y operation order for precision and overflow prevention.

  

  Filipp

  committed
  4cabeeb

  Copy full SHA for 4cabeeb

Commits on Nov 14, 2023

• add test for fixed precision issues

  bout3fiddy

  committed
  b0079e3

  Copy full SHA for b0079e3

• pack last timestamp into one uint256 and add tests

  bout3fiddy

  committed
  2f3f931

  Copy full SHA for 2f3f931

• remove asserts because packed2 values are timestamps so no need to do gas consuming checks

  bout3fiddy

  committed
  52c03cb

  Copy full SHA for 52c03cb

• claim fees before remove liq one

  bout3fiddy

  committed
  407fd0f

  Copy full SHA for 407fd0f

Commits on Nov 15, 2023

• Add multiple get_y test instances, uncomment asserts.

  

  Filipp

  committed
  91122cd

  Copy full SHA for 91122cd

• Merge branch 'feat/tests' of github.com:curvefi/twocrypto-ng into feat/tests

  

  Filipp

  committed
  2ff7b80

  Copy full SHA for 2ff7b80

Commits on Nov 22, 2023

• unsafe add nonce

  bout3fiddy

  committed
  92a0435

  Copy full SHA for 92a0435

• Merge branch 'feat/tests' of https://github.com/curvefi/twocrypto-ng into feat/tests

  bout3fiddy

  committed
  ef3491c

  Copy full SHA for ef3491c

• reduce unnecessary storage reads in some conditions in _claim_admin_fees

  bout3fiddy

  committed
  fe68f2c

  Copy full SHA for fe68f2c

• use unsafe sub for +ve timedeltas

  bout3fiddy

  committed
  6fce03c

  Copy full SHA for 6fce03c

• gas: remove unnecessary re-read of storage in remove_liquidity

  bout3fiddy

  committed
  f4ab108

  Copy full SHA for f4ab108

• add fuzz to this test

  bout3fiddy

  committed
  eb4acb3

  Copy full SHA for eb4acb3

• claim fees before deposit

  bout3fiddy

  committed
  616a278

  Copy full SHA for 616a278

• remove double mul of precisions[0]

  bout3fiddy

  committed
  ec5b122

  Copy full SHA for ec5b122

• fix: remove double mul correctly :P

  bout3fiddy

  committed
  6d80da0

  Copy full SHA for 6d80da0

• remove call to reduction coefficient

  bout3fiddy

  committed
  ba1dc63

  Copy full SHA for ba1dc63

• fix: remove double precision division

  bout3fiddy

  committed
  a3388cd

  Copy full SHA for a3388cd

• fix: use correct method_id

  bout3fiddy

  committed
  d500585

  Copy full SHA for d500585

• use correct method

  bout3fiddy

  committed
  7cabdbc

  Copy full SHA for 7cabdbc

• call ma_time instead of ma_half_time'

  bout3fiddy

  committed
  fd2e505

  Copy full SHA for fd2e505

• check A and gamma in implementation constructor and not in factory to accommodate for future updates

  bout3fiddy

  committed
  d8021ec

  Copy full SHA for d8021ec

• use DynArrays and save a bunch of gas while deploying pool

  bout3fiddy

  committed
  c81dbdc

  Copy full SHA for c81dbdc

• use immutables

  bout3fiddy

  committed
  5ae137d

  Copy full SHA for 5ae137d

• log new approval event

  bout3fiddy

  committed
  f9958d3

  Copy full SHA for f9958d3

Commits on Nov 23, 2023

• unsafe divs and muls in get_y

  bout3fiddy

  committed
  4a95cc1

  Copy full SHA for 4a95cc1

• add one unsafe add

  bout3fiddy

  committed
  0692ba9

  Copy full SHA for 0692ba9

• gas: newton_D

  bout3fiddy

  committed
  ac588b0

  Copy full SHA for ac588b0

• check nonzero math impl

  bout3fiddy

  committed
  7875cae

  Copy full SHA for 7875cae

• add salt to eip712 tyephash

  bout3fiddy

  committed
  9487057

  Copy full SHA for 9487057

Commits on Nov 24, 2023

• add more newton_D checks

  bout3fiddy

  committed
  adfed8d

  Copy full SHA for adfed8d

• fix: some errors; github workflow

  bout3fiddy

  committed
  5a03822

  Copy full SHA for 5a03822

• fix: return int instead of array of Decimal types

  bout3fiddy

  committed
  359951f

  Copy full SHA for 359951f

Commits on Nov 30, 2023

• Update test_newton_D_ref.py

  

  Filipp

  committed
  e931743

  Copy full SHA for e931743

Commits on Dec 4, 2023

• Fix newton_D_ref test params.

  

  Filipp

  committed
  cf74f17

  Copy full SHA for cf74f17

• Fix newton_D_ref test param limits.

  

  Filipp

  committed
  def5008

  Copy full SHA for def5008

• Merge branch 'feat/tests' of github.com:curvefi/twocrypto-ng into feat/tests

  

  Filipp

  committed
  75c46c1

  Copy full SHA for 75c46c1

Commits on Dec 5, 2023

• Update newton_D test.

  

  Filipp

  committed
  2b46e41

  Copy full SHA for 2b46e41

Commits on Dec 15, 2023

• fix test MAX_A lim and fix order of unpacking in amm impl constructor

  bout3fiddy

  committed
  4cc4b74

  Copy full SHA for 4cc4b74

Commits on Dec 16, 2023

• remove admin fee auto claim in add_liquidity

  bout3fiddy

  committed
  ab2080b

  Copy full SHA for ab2080b

• pack precisions and name packed gamma and A var better

  bout3fiddy

  committed
  7092010

  Copy full SHA for 7092010

Commits on Dec 18, 2023

• fix math tests

  bout3fiddy

  committed
  036a8e8

  Copy full SHA for 036a8e8

Commits on Dec 23, 2023

• stateful tests and other tests

  bout3fiddy

  committed
  6246ad9

  Copy full SHA for 6246ad9

• fix: lp price isqrt input

  bout3fiddy

  committed
  50b381b

  Copy full SHA for 50b381b

• fix: get_p test

  bout3fiddy

  committed
  b8601ae

  Copy full SHA for b8601ae