wrap pitch access in try/catch #1652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
conditionalAdd is typed as requiring note.Note -- could you shift the guard to be at the point where conditionalAdd is being called? Thanks |
mscuthbert
added a commit
that referenced
this pull request
Jan 3, 2024
Make Verticality.makeElement aware of unpitched objects. Supersedes #1652 -- which pointed out an important bug but didn't put the onus on type-safety on the calling attribute.
|
Closing in favor of #1678 which implements the same safety but in a more type-aware manner. Thanks for the great idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing with
when calling chordify() on, say, orchestral scores with timpani, etc.