Restore v0.14 lyrics #251
Merged
Restore v0.14 lyrics #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new TextAnnotation version of lyrics in VF4 is too buggy to use: lyrics are spaced beautifully normally, but can easily cause music to overflow the stave, which is impossible to use. Temporarily restore the old version of lyrics. (All the new routines are still around (in note.ts and vfShims.ts) but are not being used.) This will allow development of music21j to continue until VF5 is out and 5.1 can implement a stave overflow patch.
|
Calling this v0.16 -- so that 0.15 is an entire release on the new lyrics line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new TextAnnotation version of lyrics in VF4 is too buggy to use: lyrics are spaced beautifully normally, but can easily cause music to overflow the stave, which is impossible to use.
Temporarily restore the old version of lyrics from 0.14.x. (All the new routines are still around (in note.ts and vfShims.ts) but are not being used.)
This will allow development of music21j to continue until VF5 is out and 5.1 can implement a stave overflow patch.
Keeping in all the non-lyric improvements from 0.15 and also the ability to specify a global lyric style.