Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor quality reports #9026

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

An extract from #8953

  • Symbols in quality report computation are made public
  • Added some type annotations
  • Updated quality computation rq job status handling to include the scheduled status as well

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max zhiltsov-max requested a review from SpecLad as a code owner January 30, 2025 15:46
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 48.48485% with 51 lines in your changes missing coverage. Please review.

Project coverage is 73.75%. Comparing base (89c4af5) to head (207965b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9026   +/-   ##
========================================
  Coverage    73.74%   73.75%           
========================================
  Files          428      428           
  Lines        44502    44504    +2     
  Branches      3877     3877           
========================================
+ Hits         32820    32822    +2     
  Misses       11682    11682           
Components Coverage Δ
cvat-ui 77.44% <ø> (-0.03%) ⬇️
cvat-server 70.70% <48.48%> (+0.02%) ⬆️

@zhiltsov-max zhiltsov-max marked this pull request as draft January 31, 2025 11:56
@zhiltsov-max zhiltsov-max marked this pull request as ready for review January 31, 2025 21:39
@zhiltsov-max zhiltsov-max marked this pull request as draft February 3, 2025 13:42
@zhiltsov-max zhiltsov-max marked this pull request as ready for review February 3, 2025 13:55
@zhiltsov-max zhiltsov-max mentioned this pull request Feb 3, 2025
7 tasks
Copy link

sonarqubecloud bot commented Feb 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants