Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not keep all annotations in RAM on backup #9099

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

Eldies
Copy link
Contributor

@Eldies Eldies commented Feb 12, 2025

Motivation and context

On backup, all the annotations are kept in memory. It can be a problem if the annotations are large.
Fixing it.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Eldies Eldies requested a review from SpecLad as a code owner February 12, 2025 14:25
cvat/apps/engine/backup.py Outdated Show resolved Hide resolved
cvat/apps/engine/backup.py Outdated Show resolved Hide resolved
cvat/apps/engine/backup.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.98%. Comparing base (7ca3a31) to head (de6d3a1).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9099      +/-   ##
===========================================
+ Coverage    73.94%   73.98%   +0.03%     
===========================================
  Files          428      428              
  Lines        44532    44585      +53     
  Branches      3881     3890       +9     
===========================================
+ Hits         32930    32987      +57     
+ Misses       11602    11598       -4     
Components Coverage Δ
cvat-ui 77.55% <ø> (+0.05%) ⬆️
cvat-server 71.03% <100.00%> (+0.02%) ⬆️

cvat/apps/engine/backup.py Outdated Show resolved Hide resolved
cvat/requirements/base.in Outdated Show resolved Hide resolved
@SpecLad SpecLad merged commit a31a782 into develop Feb 13, 2025
34 checks passed
@SpecLad SpecLad deleted the dl/less-memory-on-backup branch February 13, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants