-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide production Dockerfile, pullpreview workflow and docker-build-push workflow #31
Conversation
30613d3
to
bedbe3b
Compare
a8de720
to
a781a59
Compare
@mszulik hello, and thanks for trying pullpreview. I've had a look at the pullpreview error, and pushed a fix that should help with the issue reported. Could you relaunch the workflow to see if it works now? Thanks! |
@mszulik oh I see you've fixed the formatting already, and the env is running, great! Let me know if there is anything else I can do for you :) |
Hi @crohr, thanks for the quick reaction and the fix, I will try it out later :). |
@crohr Hi, I have configured "@collaborators/push" as value for the "admins" input in the workflow, but only 1 collaborator's ssh key is added to the server instance. Did I misconfigure something? |
@mszulik I got the same report so I guess something is not working as expected when retrieving collaborators. Not sure yet if it is a permission issue or if I misunderstood what that GitHub API provides. For now I would advise you to keep declaring admins explicitly. |
@crohr Alright thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested pull preview
No description provided.