Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide production Dockerfile, pullpreview workflow and docker-build-push workflow #31

Merged
merged 39 commits into from
Jan 22, 2024

Conversation

mszulik
Copy link
Contributor

@mszulik mszulik commented Oct 26, 2023

No description provided.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@mszulik mszulik removed the request for review from gael-connan-cybex January 15, 2024 07:59
@mszulik mszulik marked this pull request as draft January 15, 2024 07:59
@mszulik mszulik added the pullpreview Deploys a preview environment on AWS Lightsail. label Jan 16, 2024
@crohr
Copy link

crohr commented Jan 16, 2024

@mszulik hello, and thanks for trying pullpreview. I've had a look at the pullpreview error, and pushed a fix that should help with the issue reported. Could you relaunch the workflow to see if it works now?

Thanks!

@crohr
Copy link

crohr commented Jan 16, 2024

@mszulik oh I see you've fixed the formatting already, and the env is running, great!

Let me know if there is anything else I can do for you :)

@mszulik
Copy link
Contributor Author

mszulik commented Jan 16, 2024

Hi @crohr, thanks for the quick reaction and the fix, I will try it out later :).

@mszulik mszulik added pullpreview Deploys a preview environment on AWS Lightsail. and removed pullpreview Deploys a preview environment on AWS Lightsail. labels Jan 16, 2024
@mszulik mszulik added the pullpreview Deploys a preview environment on AWS Lightsail. label Jan 18, 2024
@mszulik
Copy link
Contributor Author

mszulik commented Jan 18, 2024

@crohr Hi, I have configured "@collaborators/push" as value for the "admins" input in the workflow, but only 1 collaborator's ssh key is added to the server instance. Did I misconfigure something?

@crohr
Copy link

crohr commented Jan 18, 2024

@mszulik I got the same report so I guess something is not working as expected when retrieving collaborators. Not sure yet if it is a permission issue or if I misunderstood what that GitHub API provides. For now I would advise you to keep declaring admins explicitly.

@mszulik
Copy link
Contributor Author

mszulik commented Jan 18, 2024

@crohr Alright thank you!

@mszulik mszulik added pullpreview Deploys a preview environment on AWS Lightsail. and removed pullpreview Deploys a preview environment on AWS Lightsail. labels Jan 18, 2024
@gael-connan-cybex gael-connan-cybex added the pullpreview Deploys a preview environment on AWS Lightsail. label Jan 18, 2024
Copy link
Contributor

@gael-connan-cybex gael-connan-cybex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested pull preview

@mszulik mszulik removed the pullpreview Deploys a preview environment on AWS Lightsail. label Jan 19, 2024
README.md Outdated Show resolved Hide resolved
@gael-connan-cybex gael-connan-cybex added pullpreview Deploys a preview environment on AWS Lightsail. and removed pullpreview Deploys a preview environment on AWS Lightsail. labels Jan 22, 2024
@mszulik mszulik merged commit f5b03e9 into main Jan 22, 2024
7 checks passed
@mszulik mszulik deleted the feature/docker branch January 22, 2024 14:40
@github-actions github-actions bot removed the pullpreview Deploys a preview environment on AWS Lightsail. label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants