CM-24180 support zip scan for repository #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2023 17:03
add support for secret scanning using the ScanService
add support for secret scanning using the ScanService
galdavidi
requested review from
MarshalX,
MichalBor,
MaorDavidzon and
artem-fedorov
as code owners
make the if shorter
avishaiamiel
requested changes
Jul 2, 2023
Comment on lines
+995
to
+996
| # get the full path by combining file_path and file_name | ||
| return f"{detection['detection_details']['file_path']}{detection['detection_details']['file_name']}" |
There was a problem hiding this comment.
Extract to method - get_secret_detection_full_path and in the comment maybe add an example instead of explain the code below for better readibility.
| @@ -7,6 +7,7 @@ | |||
| from . import models | |||
| from .cycode_client_base import CycodeClientBase | |||
| from .scan_config.scan_config_base import ScanConfigBase | |||
| from ..cli.consts import SECRET_SCAN_TYPE | |||
There was a problem hiding this comment.
For consistency with other modules in the project from cycode.cli.consts
Comment on lines
+46
to
+47
| if scan_type == SECRET_SCAN_TYPE: | ||
| scan_type = "secrets" #the scanService endpoint is secrets and not secret |
There was a problem hiding this comment.
extract to method - get_scan_uri which will return {scan_type}/repository.
if secret
return secrets/repository
else
{scan_type}/repository
anyway, avoid overriding method input and I think that it will be clear so you can skip the comment.
doratias18
changed the title
|
@galdavidi , this PR is still relevant? |
that's duplicate of #136. im waiting for BE chabges first. not merged yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cm 24180 support zip scan for repository
enable to scan files for secreats using the Cycode-cli