Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-32048 - Fix secret scan via detector service #210

Merged
merged 4 commits into from
Feb 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cycode/cyclient/scan_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,14 @@ def __init__(

self._hide_response_log = hide_response_log

def get_scan_controller_path(self, scan_type: str) -> str:
def get_scan_controller_path(self, scan_type: str, should_use_scan_service: bool = False) -> str:
if scan_type == consts.INFRA_CONFIGURATION_SCAN_TYPE:
# we don't use async flow for IaC scan yet
return self._SCAN_SERVICE_CONTROLLER_PATH
if not should_use_scan_service and scan_type == consts.SECRET_SCAN_TYPE:
MarshalX marked this conversation as resolved.
Show resolved Hide resolved
# if a secret scan goes to detector directly, we should not use CLI controller.
# CLI controller belongs to the scan service only
return self._SCAN_SERVICE_CONTROLLER_PATH

return self._SCAN_SERVICE_CLI_CONTROLLER_PATH

Expand Down
Loading