Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-34882 - Add one report URL for all secrets found in the same scan #228

Merged
merged 10 commits into from
May 28, 2024
Merged

CM-34882 - Add one report URL for all secrets found in the same scan #228

merged 10 commits into from
May 28, 2024

Conversation

saramontif
Copy link
Contributor

No description provided.

MarshalX
MarshalX reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@MarshalX MarshalX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Pls add support for JSON printer and update branch

cycode/cli/commands/scan/code_scanner.py Outdated Show resolved Hide resolved
cycode/cli/commands/scan/code_scanner.py Outdated Show resolved Hide resolved
cycode/cli/commands/scan/code_scanner.py Outdated Show resolved Hide resolved
cycode/cli/printers/tables/table_printer_base.py Outdated Show resolved Hide resolved
cycode/cyclient/scan_client.py Outdated Show resolved Hide resolved
MarshalX
MarshalX reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@MarshalX MarshalX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add support for JSON printer and update branch

cycode/cli/commands/scan/code_scanner.py Outdated Show resolved Hide resolved
cycode/cli/commands/scan/code_scanner.py Outdated Show resolved Hide resolved
cycode/cli/commands/scan/code_scanner.py Outdated Show resolved Hide resolved
cycode/cli/commands/scan/code_scanner.py Outdated Show resolved Hide resolved
MarshalX
MarshalX reviewed May 23, 2024
View reviewed changes
Copy link
Collaborator

@MarshalX MarshalX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table output still return many report url. probably because of described conversations below. pls update branch. everything else is good!

cycode/cli/commands/scan/code_scanner.py Outdated Show resolved Hide resolved
cycode/cli/printers/tables/table_printer.py Outdated Show resolved Hide resolved
cycode/cli/printers/tables/table_printer.py Outdated Show resolved Hide resolved
@MarshalX MarshalX changed the title CM-34882-Add support one report url CM-34882 - Add one report URL for all secrets found in the same scan May 23, 2024
@MarshalX
Copy link
Collaborator

pls update our e2e tests for CLI after merging. they will probably break because of changes in printers. 'Report URL' instead of 'Report URLs:`

@saramontif saramontif merged commit 8b91279 into main May 28, 2024
24 checks passed
@saramontif saramontif deleted the CM-34882-support-one-report-url branch May 28, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshalX MarshalX MarshalX approved these changes

@MichalBor MichalBor Awaiting requested review from MichalBor MichalBor is a code owner

@MaorDavidzon MaorDavidzon Awaiting requested review from MaorDavidzon MaorDavidzon is a code owner

@artem-fedorov artem-fedorov Awaiting requested review from artem-fedorov

@elsapet elsapet Awaiting requested review from elsapet elsapet is a code owner

@gotbadger gotbadger Awaiting requested review from gotbadger gotbadger is a code owner

@cfabianski cfabianski Awaiting requested review from cfabianski cfabianski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saramontif @MarshalX