CM-35347 - Use relative paths in the tree view

cycodehq · May 6, 2024 · d5ad9a6 · d5ad9a6
1 parent 968d70b
commit d5ad9a6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/providers/tree-view/utils.ts b/src/providers/tree-view/utils.ts
@@ -3,6 +3,7 @@ import {AnyDetection, IacDetection, SastDetection, ScaDetection, SecretDetection
 import {FileScanResult} from './provider';
 import {SeverityFirstLetter, TreeView, TreeViewDisplayedData} from './types';
 import {ScanType, SEVERITY_PRIORITIES} from '../../constants';
+import {cliService} from '../../services/CliService';
 
 interface RefreshTreeViewDataArgs {
   detections: AnyDetection[];
@@ -27,11 +28,14 @@ export function refreshTreeViewData(
     return;
   }
 
+  const projectRoot = cliService.getProjectRootDirectory();
+
   const {provider} = treeView;
   const affectedFiles: FileScanResult[] = [];
   const detectionsMapped = mapDetectionsByFileName(detections, scanType);
   detectionsMapped.forEach((vulnerabilities, fullFilePath) => {
-    affectedFiles.push(new FileScanResult(fullFilePath, fullFilePath, vulnerabilities));
+    const projectRelativePath = path.relative(projectRoot, fullFilePath);
+    affectedFiles.push(new FileScanResult(projectRelativePath, fullFilePath, vulnerabilities));
   });
   provider.refresh(affectedFiles, scanType);
 }

diff --git a/src/services/scanners/IacScanner.ts b/src/services/scanners/IacScanner.ts
@@ -1,4 +1,5 @@
 import * as vscode from 'vscode';
+import * as path from 'path';
 import {extensionOutput} from '../../logging/extension-output';
 import {cliWrapper} from '../../cli-wrapper/cli-wrapper';
 import statusBar from '../../utils/status-bar';
@@ -162,8 +163,11 @@ const detectionsToDiagnostics = async (
 
     let message = `Severity: ${detection.severity}\n`;
     message += `Description: ${detection.message}\n`;
+
     message += `IaC Provider: ${detection.detection_details.infra_provider}\n`;
-    message += `In file: ${detection.detection_details.file_name}\n`;
+
+    const fileName = path.basename(detection.detection_details.file_name);
+    message += `In file: ${fileName}\n`;
 
     const diagnostic = new vscode.Diagnostic(
         document.lineAt(detection_details.line_in_file - 1).range,