review amends

cylc/flow/scheduler_cli.py

@@ -424,10 +424,11 @@ async def scheduler_cli(
     )
 
     # run the workflow
-    # ret = asyncio.new_event_loop().run_until_complete(_run(scheduler))
     if options.no_detach:
         ret = await _run(scheduler)
     else:
+        # Note: The daemonization messes with asyncio so we have to start a
+        # new event loop if detaching
         ret = asyncio.run(
             _run(scheduler)
         )

cylc/flow/scripts/reinstall.py

@@ -157,8 +157,7 @@ def main(
     opts: 'Values',
     *ids: str
 ) -> None:
-    # """CLI wrapper."""
-    # reinstall_cli(opts, args)
+    """CLI wrapper."""
     call_multi(
         partial(reinstall_cli, opts),
         *ids,

cylc/flow/scripts/validate_reinstall.py

@@ -125,10 +125,10 @@ def check_tvars_and_workflow_stopped(
 
 @cli_function(get_option_parser)
 def main(parser: COP, options: 'Values', workflow_id: str):
-    sys.exit(asyncio.run(vro_cli(parser, options, workflow_id)))
+    sys.exit(asyncio.run(vr_cli(parser, options, workflow_id)))
 
 
-async def vro_cli(parser: COP, options: 'Values', workflow_id: str):
+async def vr_cli(parser: COP, options: 'Values', workflow_id: str):
     """Run Cylc (re)validate - reinstall - reload in sequence."""
     # Attempt to work out whether the workflow is running.
     # We are trying to avoid reinstalling then subsequently being

tests/integration/test_reinstall.py

@@ -19,6 +19,7 @@
 from pathlib import Path
 from types import SimpleNamespace
 from uuid import uuid1
+from functools import partial
 
 import pytest
 
@@ -37,7 +38,7 @@
 from cylc.flow.workflow_files import (
     WorkflowFiles,
 )
-
+from cylc.flow.network.multi import call_multi
 
 ReInstallOptions = Options(reinstall_gop())
 
@@ -89,8 +90,6 @@ def one_run(one_src, test_dir, run_dir):
         id=str(w_run_dir.relative_to(run_dir)),
     )
 
-from functools import partial
-from cylc.flow.network.multi import call_multi
 
 async def test_rejects_random_workflows(one, one_run):
     """It should only work with workflows installed by cylc install."""