Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get poll to return task failure if job/log has been removed. #6577

Open
wants to merge 3 commits into
base: 8.4.x
Choose a base branch
from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 28, 2025

Closes #6425

Note

Note to reviewers, you will need to deploy this branch onto remote platforms to confirm it works for remote filesystems.

Finally have a replicable example (Thank you @oliver-sanders)

[scheduling]
    cycling mode = integer
    [[graph]]
        R1 = task

[runtime]
    [[task]]
        script = """
            rm ${CYLC_WORKFLOW_RUN_DIR}/.service/contact
            rm -r "${CYLC_WORKFLOW_RUN_DIR}/log/job/${CYLC_TASK_CYCLE_POINT}/${CYLC_TASK_NAME}"
        """
        platform = _remote_pbs

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim self-assigned this Jan 28, 2025
@wxtim wxtim marked this pull request as draft January 28, 2025 16:17
@wxtim wxtim added this to the 8.4.1 milestone Jan 28, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only test__job_poll_status_files_deleted_logdir is directly related to the PR. Other tests should increase coverage. 😄

@wxtim wxtim force-pushed the fix.handle_deletion_of_job_logs branch 2 times, most recently from 2661a36 to 01c7cb8 Compare January 28, 2025 17:30
@wxtim wxtim requested review from MetRonnie and oliver-sanders and removed request for MetRonnie January 28, 2025 17:30
@wxtim wxtim marked this pull request as ready for review January 28, 2025 17:30
@wxtim wxtim marked this pull request as draft January 29, 2025 09:24
added unit tests for JobRunnerMgr._jobs_poll_status_files

test the task_job_mgr end
@wxtim wxtim force-pushed the fix.handle_deletion_of_job_logs branch from 01c7cb8 to 31fd08f Compare January 29, 2025 09:27
@wxtim wxtim requested a review from MetRonnie January 29, 2025 11:04
@wxtim wxtim marked this pull request as ready for review January 29, 2025 11:04
@wxtim wxtim linked an issue Jan 29, 2025 that may be closed by this pull request
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cylc/flow/task_job_mgr.py Outdated Show resolved Hide resolved
cylc/flow/job_runner_mgr.py Outdated Show resolved Hide resolved
@oliver-sanders
Copy link
Member

Note to reviewers, you will need to deploy this branch onto remote platforms to confirm it works for remote filesystems.

@wxtim wxtim force-pushed the fix.handle_deletion_of_job_logs branch from 54afde3 to 0c110b3 Compare February 3, 2025 11:52
@wxtim wxtim requested a review from oliver-sanders February 3, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle job log directory deleted for active task
2 participants