-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get poll to return task failure if job/log has been removed. #6577
base: 8.4.x
Are you sure you want to change the base?
Conversation
tests/unit/test_job_runner_mgr.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only test__job_poll_status_files_deleted_logdir
is directly related to the PR. Other tests should increase coverage. 😄
2661a36
to
01c7cb8
Compare
added unit tests for JobRunnerMgr._jobs_poll_status_files test the task_job_mgr end
01c7cb8
to
31fd08f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note to reviewers, you will need to deploy this branch onto remote platforms to confirm it works for remote filesystems. |
Co-authored-by: Oliver Sanders <[email protected]>
54afde3
to
0c110b3
Compare
Closes #6425
Note
Note to reviewers, you will need to deploy this branch onto remote platforms to confirm it works for remote filesystems.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).?.?.x
branch.