Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing TS1016 when using TypeScript on package superdilithium #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BadAimWeeb
Copy link

node_modules/superdilithium/index.d.ts:105:4 - error TS1016: A required parameter cannot follow an optional parameter.

105    includeHash: true
       ~~~~~~~~~~~

node_modules/superdilithium/index.d.ts:129:4 - error TS1016: A required parameter cannot follow an optional parameter.

129    includeHash: true
       ~~~~~~~~~~~

node_modules/superdilithium/index.d.ts:185:4 - error TS1016: A required parameter cannot follow an optional parameter.

185    includeHash: true
       ~~~~~~~~~~~


Found 3 errors in the same file, starting at: node_modules/superdilithium/index.d.ts:105

So I changed it to be

includeHash?: boolean

instead since that's what it supposed to be.

@BadAimWeeb BadAimWeeb changed the title Fixing TS1016 when using TypeScript Fixing TS1016 when using TypeScript on package superdilithium Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant