forked from hashicorp/terraform-provider-rabbitmq
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added and fixed shovel parameters and added vhost options and limits #66
Open
Galvill
wants to merge
9
commits into
cyrilgdn:master
Choose a base branch
from
Galvill:vhost-options-and-limits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estination_publish_properties
Added destination_queue_arguments; fixed destination_properties and …
Hi @cyrilgdn, can you please take a look at this? |
Hi @Galvill, while waitting that your PR is merged, i forked it to my repository. Thanks to your work. terraform {
required_providers {
rabbitmq = {
source = "rfd59/rabbitmq"
version = "2.0.0"
}
}
} |
We're using this fork in production with success, please consider to merge it and release a new version please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped rabbit-hole to v2.15.0
Ran all acceptance tests successfully
Replaces PR #64
It also replaces PR #55
Changes to shovel parameters:
destination_properties - Changed type from string to map
destination_publish_properties - Changed type from string to map
destination_queue_arguments - Added (map)
Important Note:
A state that contains shovel information created by an earlier version of the provider will cause an error because the provider expects "destination_properties" and "destination_publish_properties" to be of type map, but in the state, they will exist as strings.
This can be fixed by modifying the state file and changing the double quotes ( "" ) with curly brackets ( {} )
Added support for additional vhost parameters:
Description - (Optional) A friendly description.
default_queue_type - (Optional) default queue type for new queues
max_connections - (Optional) Maximum number of concurrent client connections to the vhost
max_queues - (Optional) Maximum number of queues that can be created on the vhost