-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added side-by-side categorical hist plotting example #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I wrote a couple of comments.
import boost_histogram as bh | ||
import numpy as np | ||
import matplotlib.pyplot as plt | ||
import plothist # For the style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is only for the style, does it belong to the plothist documentation? Especially in the first page of the documentation (1D histograms)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can discuss, for now I move it to Other complex examples section. I really like having this plot in the gallery, and it is much easier to do with boost-histogram than matplotlib.
https://www.1001fonts.com/download/latin-modern-roman.zip seems down for the moment, so the pytests are failing. I'll relaunch them when the website is up again. |
@0ctagon Approved, but please check my comment before merging. |
Added this example, requested multiple times by users.