Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added side-by-side categorical hist plotting example #153

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

0ctagon
Copy link
Collaborator

@0ctagon 0ctagon commented May 20, 2024

Added this example, requested multiple times by users.

@0ctagon 0ctagon requested a review from cyrraz May 20, 2024 02:50
Copy link
Owner

@cyrraz cyrraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I wrote a couple of comments.

docs/examples/1d_hist/1d_side_by_side.py Outdated Show resolved Hide resolved
import boost_histogram as bh
import numpy as np
import matplotlib.pyplot as plt
import plothist # For the style
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is only for the style, does it belong to the plothist documentation? Especially in the first page of the documentation (1D histograms)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can discuss, for now I move it to Other complex examples section. I really like having this plot in the gallery, and it is much easier to do with boost-histogram than matplotlib.

docs/examples/1d_hist/1d_side_by_side.py Outdated Show resolved Hide resolved
docs/examples/1d_hist/1d_side_by_side.py Outdated Show resolved Hide resolved
docs/examples/1d_hist/1d_side_by_side.py Outdated Show resolved Hide resolved
docs/img/1d_side_by_side.svg Outdated Show resolved Hide resolved
docs/examples/1d_hist/1d_side_by_side.py Outdated Show resolved Hide resolved
docs/examples/1d_hist/1d_side_by_side.py Outdated Show resolved Hide resolved
docs/examples/1d_hist/1d_side_by_side.py Outdated Show resolved Hide resolved
docs/examples/1d_hist/1d_side_by_side.py Outdated Show resolved Hide resolved
@0ctagon
Copy link
Collaborator Author

0ctagon commented May 22, 2024

https://www.1001fonts.com/download/latin-modern-roman.zip seems down for the moment, so the pytests are failing. I'll relaunch them when the website is up again.

docs/examples/advanced/1d_side_by_side.py Outdated Show resolved Hide resolved
@cyrraz
Copy link
Owner

cyrraz commented Jun 8, 2024

@0ctagon Approved, but please check my comment before merging.

@0ctagon 0ctagon merged commit 55aca57 into main Jun 10, 2024
5 checks passed
@0ctagon 0ctagon deleted the doc-side-by-side-hist-ex branch June 10, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants