Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1d side by side update #171

Merged
merged 9 commits into from
Jun 27, 2024
Merged

1d side by side update #171

merged 9 commits into from
Jun 27, 2024

Conversation

0ctagon
Copy link
Collaborator

@0ctagon 0ctagon commented Jun 27, 2024 •
edited
Loading

Using a simple plot_hist now. Put the example in 1D hist chapter, Histogram with category axis section.

Doc: https://plothist.readthedocs.io/en/1d_side_by_side_update/basics/1d_hist.html#histogram-with-category-axis

@0ctagon 0ctagon requested a review from cyrraz June 27, 2024 05:36
cyrraz
cyrraz requested changes Jun 27, 2024
View reviewed changes
docs/basics/1d_hist.rst Outdated Show resolved Hide resolved
@0ctagon 0ctagon requested a review from cyrraz June 27, 2024 08:27
cyrraz
cyrraz requested changes Jun 27, 2024
View reviewed changes
Copy link
Owner

@cyrraz cyrraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example, we are nearly there.

docs/basics/1d_hist.rst Outdated Show resolved Hide resolved
docs/basics/1d_hist.rst Outdated Show resolved Hide resolved
docs/examples/advanced/1d_side_by_side_with_numbers.py Outdated Show resolved Hide resolved
src/plothist/plotters.py Outdated Show resolved Hide resolved
@0ctagon 0ctagon requested a review from cyrraz June 27, 2024 09:03
@0ctagon 0ctagon merged commit bf669c4 into main Jun 27, 2024
5 checks passed
@0ctagon 0ctagon deleted the 1d_side_by_side_update branch June 27, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrraz cyrraz cyrraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0ctagon @cyrraz