-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compatibility with mplhep #177
base: mpldev
Are you sure you want to change the base?
Conversation
In the end I think we want merge this into |
After reviewing the new svgs without modifying mplhep (fa01534), I see 3 main differences, and I fixed 2 of them in the last commit (c0a124b) by modifying a bit mplhep
2.5. A side effect of the
PS1: I changed the PS2: In PS3: Pytest not agreeing is because it is making the plots with the released version of matplotlib, not the one I modified locally. We could put those modifications on a mpldev branch in mplhep and install this branch in the gha. PS4: It's really nice that it agrees quite well with little modifications 😃 |
Replacing
and no plot changed. For
I think more work is needed to see how our |
2a45b94 implemented |
I updated the figures to correspond to the output of the current mplhep/plothist code. I think some default parameters could be changed, like the dot size or the grayness of the hashing. I would also change our default histograms with something without errors by default, so it doesn't overcrowd the plots. But for now every examples are working well with only using mplhep as a backend for plotting. I think we should merge this before opening another PR to focus on removing boost-histogram dependency (which will be easier to review with this PR merged already). |
This is still a draft, but I am opening it now to get CI running...