Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: serialize in asScalar #144

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

ZirgVoice
Copy link
Contributor

added serialize to asScalar function and fix swift 6 warnings

I encountered the bug described here. This pull request fixes it.

added serialize to asScalar function and fix swift 6 warnings
d-exclaimation
d-exclaimation previously approved these changes Nov 16, 2024
@d-exclaimation
Copy link
Owner

Looks good to me, seemed like the pipeline is failing because the version of Swift 5 is too old, can you swap that out from 5.6 to 5.10 or just remove that one.

@d-exclaimation
Copy link
Owner

Looks good to me, seemed like the pipeline is failing because the version of Swift 5 is too old, can you swap that out from 5.6 to 5.10 or just remove that one.

I made those changes, all is required now is to rebase/merge main to this PR

added serialize to asScalar function and fix swift 6 warnings
…/pioneer into serialize-in-id-scalar

# Conflicts:
#	Package.swift
d-exclaimation
d-exclaimation previously approved these changes Nov 16, 2024
@ZirgVoice ZirgVoice dismissed d-exclaimation’s stale review November 16, 2024 23:07

The merge-base changed after approval.

@ZirgVoice
Copy link
Contributor Author

Something weird is going on, maybe you can figure out why it doesn't recognize it as a string

Bildschirmfoto 2024-11-17 um 11 20 06

@ZirgVoice
Copy link
Contributor Author

And on the main branch, the tests testStatelessRequest and testInvalidStatelessRequest fail with a memory access error A bad access to memory terminated the process.

@d-exclaimation
Copy link
Owner

d-exclaimation commented Nov 17, 2024

Weird, I can investigate later but last I checked it runs fine on main.

I'll double check as well what's up with ID

I do remember that there's some work done to make this work with Swift 6 (mainly just making sure everything work with the breaking changes)

@ZirgVoice
Copy link
Contributor Author

I'll double check as well what's up with ID

I fixed the type cast. Not sure if it's the right fix, but it works.

Weird, I can investigate later but last I checked it runs fine on main.

I still haven't figured this out, maybe the error only appears on MacOS

d-exclaimation
d-exclaimation previously approved these changes Nov 28, 2024
@ZirgVoice ZirgVoice dismissed d-exclaimation’s stale review November 28, 2024 00:45

The merge-base changed after approval.

@ZirgVoice
Copy link
Contributor Author

@d-exclaimation ping on this

@d-exclaimation d-exclaimation merged commit 210d7de into d-exclaimation:main Dec 19, 2024
1 check passed
@d-exclaimation
Copy link
Owner

Should be part of v1.4.1

@ZirgVoice ZirgVoice deleted the serialize-in-id-scalar branch January 30, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants