-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added: serialize in asScalar #144
added: serialize in asScalar #144
Conversation
added serialize to asScalar function and fix swift 6 warnings
Looks good to me, seemed like the pipeline is failing because the version of Swift 5 is too old, can you swap that out from 5.6 to 5.10 or just remove that one. |
I made those changes, all is required now is to rebase/merge main to this PR |
added serialize to asScalar function and fix swift 6 warnings
…/pioneer into serialize-in-id-scalar # Conflicts: # Package.swift
The merge-base changed after approval.
And on the |
Weird, I can investigate later but last I checked it runs fine on main. I'll double check as well what's up with ID I do remember that there's some work done to make this work with Swift 6 (mainly just making sure everything work with the breaking changes) |
I fixed the type cast. Not sure if it's the right fix, but it works.
I still haven't figured this out, maybe the error only appears on MacOS |
The merge-base changed after approval.
@d-exclaimation ping on this |
Should be part of |
added serialize to asScalar function and fix swift 6 warnings
I encountered the bug described here. This pull request fixes it.