BL/BU: Handle bad bootloaders #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defensive measure against bootloaders (possibly from other projects) leaving things running.
Some bootloaders set it to our initial SP and then some compiler generated code increments it off the top of the stack before branching to firmware... so we ensure it is correct before using the stack.
|
@mlyle I dropped the commit which switched from newlib-nano to newlib. |
|
jenkins, build artifacts please |
Gives the compiler no chance to insert garbage code. Before it was inserting in between setting MSP to initial SP and branching to initial PC:
ldmia.w sp!, {r4, r5, r6, lr}
(ldm = load multiple, ia = increment after... this tries to pop off the stack after setting SP to the new stack top)
|
jenkins, build artifacts please |
yamahabest
reviewed
Jul 3, 2017
| @@ -1,12 +1,12 @@ | |||
| BOARD_TYPE := 0x94 | |||
| BOARD_REVISION := 0x01 | |||
| BOOTLOADER_VERSION := 0x87 | |||
| BOOTLOADER_VERSION := 0x88 | |||
There was a problem hiding this comment.
It is already 0x88 at next, shouldn't it be 0x89 now?
There was a problem hiding this comment.
Would require a rebase and it's only been at 0x88 for a couple of days... will just ignore ;)
|
Artifacts built, by request of @tracernz |
|
OMG thanks. |
|
thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and working on Revo:
Fixes #1689 (issue detailed in #1689 (comment))
Remaining questions: