Support :as #6
Closed
Support :as #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for {:as ...} for streams, text, and byte arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #3. I took a shortcut compared to the suggestion in the ticket; namely, I think it's OK to coerce things to a stream and from a stream to the desired thing, so that there isn't this 3x3 matrix of conversions, just to and from streams. That means it does more work than it needs to, but it reduces the amount of code. I also took a non-standard approach to the tests: I reused the coercer to reverse the coercion and make sure we had the right thing. Otherwise, I'd basically just have to repeat the coercion logic in the test.