Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradlew to 8.12 (enables building on Mac) #19

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

hillcg-aws
Copy link
Collaborator

When using gradle 7.x and JDK 21 on Mac the "build" target fails with messsages akin to "failed to create Jar file". This is no longer the case with gradle 8.x series.

When using gradle 7.x and JDK 21 on Mac the "build" target fails with
messsages akin to "failed to create Jar file". This is no longer the
case with gradle 8.x series.
Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely in favor of upgrading, but I'm a bit surprised this is the only necessary change. Don't the gradlew/gradlew.bat files have to be refreshed as well at least?

@hillcg-aws
Copy link
Collaborator Author

Fair point, updated the PR with the entire "gradle wrapper" upgrade

Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robin-aws robin-aws merged commit 2773fed into dafny-lang:main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants