Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only retrieve task-level info for mapped dags #27408

Open
wants to merge 1 commit into
base: dpeng817/change_default_sensor_interval
Choose a base branch
from

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Jan 27, 2025

Summary & Motivation

Changes airlift internals to only make expensive dag-level calls for task info when absolutely necessary.

This speeds up initial load significantly. For 200 dags, 90s -> 50s.

How I Tested These Changes

Changelog

  • [dagster-airlift] fixed some scaling issues which were causing slow initial load times for code locations including dagster-airlift code.

Copy link
Contributor Author

dpeng817 commented Jan 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dpeng817 dpeng817 force-pushed the dpeng817/dont_compute_everything branch from 6f64cd6 to ee14a5e Compare January 28, 2025 00:58
@dpeng817 dpeng817 requested a review from benpankow January 31, 2025 01:50
@dpeng817 dpeng817 marked this pull request as ready for review January 31, 2025 01:50
@dpeng817 dpeng817 force-pushed the dpeng817/change_default_sensor_interval branch from 5fc0913 to 07a4a2e Compare January 31, 2025 23:02
@dpeng817 dpeng817 force-pushed the dpeng817/dont_compute_everything branch from ee14a5e to 7d4d050 Compare January 31, 2025 23:02
@dpeng817 dpeng817 force-pushed the dpeng817/change_default_sensor_interval branch from 07a4a2e to 1a053da Compare January 31, 2025 23:08
@dpeng817 dpeng817 force-pushed the dpeng817/dont_compute_everything branch from 7d4d050 to 5124638 Compare January 31, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants